Thread (25 messages) 25 messages, 3 authors, 2019-06-08

Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2019-06-06 19:04:11
Also in: linux-devicetree, lkml

On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote:
quoted
quoted
+
+	misc_deregister(&xsdfec->miscdev);
+	atomic_dec(&xsdfec_ndevs);
+	return 0;
You free nothing?

You are leaking resources like crazy here, this is not ok at all.
The managed resources are used.
Anyway, I'll test for memory leak and search for the answer.
Oops, no, you are right, I missed the "devm" prefix on those calls.  My
fault.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help