Thread (26 messages) 26 messages, 4 authors, 2019-04-25

Re: [PATCH v2 02/14] mbox: qcom: add APCS child device for QCS404

From: Stephen Boyd <sboyd@kernel.org>
Date: 2019-02-22 18:09:21
Also in: linux-arm-msm, linux-clk, linux-devicetree, lkml

Quoting Jorge Ramirez-Ortiz (2019-01-28 10:32:49)
quoted hunk ↗ jump to hunk
There is clock controller functionality in the APCS hardware block of
qcs404 devices similar to msm8916.

Co-developed-by: Niklas Cassel <redacted>
Signed-off-by: Niklas Cassel <redacted>
Signed-off-by: Jorge Ramirez-Ortiz <redacted>
---
 drivers/mailbox/qcom-apcs-ipc-mailbox.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 3cf2937..0d64aa5 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -97,16 +97,21 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
                return ret;
        }
 
-       if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
-               apcs->clk = platform_device_register_data(&pdev->dev,
-                                                         "qcom-apcs-msm8916-clk",
-                                                         -1, NULL, 0);
-               if (IS_ERR(apcs->clk))
-                       dev_err(&pdev->dev, "failed to register APCS clk\n");
-       }
-
        platform_set_drvdata(pdev, apcs);
 
+       if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") ||
+           of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global"))
+               goto register_clk;
This goto is weird style, but I'm not the maintainer here. Maybe just do
an if condition with the body of the if inside like normally is done and
suffer the indenting pain?


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help