Re: [PATCH v3 3/6] media: sun6i: Set 300MHz mod clock for A64
From: Maxime Ripard <hidden>
Date: 2018-12-11 15:44:33
Also in:
linux-devicetree, linux-media, lkml
On Mon, Dec 10, 2018 at 05:22:43PM +0530, Jagan Teki wrote:
quoted hunk ↗ jump to hunk
The default CSI_SCLK seems unable to drive the sensor to capture the image, so update it to working clock rate 300MHz for A64. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index bbe45e893722..4b872800b244 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c@@ -822,6 +822,11 @@ static int sun6i_csi_resource_request(struct sun6i_csi_dev *sdev, return PTR_ERR(sdev->clk_mod); } + /* A64 need 300MHz mod clock to operate properly */ + if (of_device_is_compatible(pdev->dev.of_node, + "allwinner,sun50i-a64-csi")) + clk_set_rate_exclusive(sdev->clk_mod, 300000000); +
Where is that 300MHz coming from? You claim in your comment that it "operates properly", yet in your previous mail about this, you were saying that 1080p @30Hz is broken. Which one is it? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com