[PATCH 6/6] arm64: dts: marvell: Add cpu clock node on Armada 7K/8K
From: sboyd@kernel.org (Stephen Boyd)
Date: 2018-10-12 17:42:19
Also in:
linux-clk, lkml
+Rob Quoting Gregory CLEMENT (2018-09-22 11:17:09)
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi index 4a65e4e830aa..27c840e91abe 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi@@ -280,6 +280,12 @@ #address-cells = <1>; #size-cells = <1>; + cpu_clk: clock-cpu { + compatible = "marvell,ap806-cpu-clock"; + clocks = <&ap_clk 0>, <&ap_clk 1>; + #clock-cells = <1>; + };
This looks like the wrong place because there isn't a reg property. It should go to the root of the tree. And then it looks like we're adding something to DT to get a driver to probe, which is improper DT design.