Thread (36 messages) 36 messages, 6 authors, 2018-09-14

[PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

From: clg@kaod.org (Cédric Le Goater)
Date: 2018-09-14 06:16:02
Also in: linux-aspeed, linux-i2c, lkml, openbmc

quoted
quoted
That seems to suggest that none of the status bits auto-clears, and that
the above code clearing intr_status should be removed entirely.
Am I missing something ?
You are right. I just pushed another version of the previous patch with this
new hunk :
@@ -188,7 +200,6 @@ static void aspeed_i2c_bus_handle_cmd(As
? {
????? bus->cmd &= ~0xFFFF;
????? bus->cmd |= value & 0xFFFF;
-??? bus->intr_status = 0;
? ????? if (bus->cmd & I2CD_M_START_CMD) {
????????? uint8_t state = aspeed_i2c_get_state(bus) & I2CD_MACTIVE ?


The QEMU palmetto and witherspoon machines seem to behave fine. Can you give
it a try ?
Works fine for me for all affected qemu platforms.

How do you want to proceed with the qemu patches ? I attached my patches
for reference. Maybe you can add them to your tree if they are ok and submit
the entire series together to the qemu mailing list ?
yes. They are pushed in my aspeed-3.1 branch. I will send the series 
on the list.

Thanks,

C. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help