Thread (36 messages) 36 messages, 6 authors, 2018-09-14

[PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

From: joel@jms.id.au (Joel Stanley)
Date: 2018-09-11 22:53:44
Also in: linux-aspeed, linux-i2c, lkml, openbmc

On Wed, 12 Sep 2018 at 07:48, Jae Hyun Yoo [off-list ref] wrote:
On 9/11/2018 1:41 PM, Guenter Roeck wrote:
quoted
On Tue, Sep 11, 2018 at 01:30:41PM -0700, Jae Hyun Yoo wrote:
quoted
quoted
I checked this patch again but it doesn't have any change that could
affect to the probing flow. I'll debug the issue on qemu 3.0 environment
and will share if I find something.
The problem may be that qemu and the new code disagree how interrupts
should be generated and handled, and the new code does not handle the
interrupts it receives from the simulated hardware. This will result
in i2c device probe failure, which in turn can cause all kinds of
problems.
Yes, that makes sense. Looks like it should be reverted until the issue
is fixed. Will submit a patch to revert it.
Let's not rush. The qemu model was written in order to allow us to
test the kernel code, and was validated by the kernel driver we have.
We've had situations in the past (with the i2c driver in fact) where a
change in the driver required an update of the model to be more
accurate.

I suggest we wait until Cedric has a chance to look at the issue
before reverting the patch.

Cheers,

Joel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help