Hi Ezequiel,

Ezequiel Garcia [off-list ref] wrote on Fri, 27 Jul
2018 13:13:20 -0300:

Hi Miquel,

You know, it is usually useful to Cc the author of the lines a patch touches :-)

I have to admit I limited the CC list to the get_maintainers.pl output.
But for sure I can add you for further changes :)

On 16 July 2018 at 11:41, Miquel Raynal [off-list ref] wrote:

quoted

Prepare the migration to use regmaps by first simplifying the
initialization functions: avoid unnecessary write/read cycles on
configuration registers.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/thermal/armada_thermal.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 077e8e562306..6fdb90b3c001 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c

@@ -103,16 +103,13 @@ static void armadaxp_init_sensor(struct platform_device *pdev,

        reg = readl_relaxed(priv->control1);
        reg |= PMU_TDC0_OTF_CAL_MASK;
-       writel(reg, priv->control1);

        /* Reference calibration value */
        reg &= ~PMU_TDC0_REF_CAL_CNT_MASK;
        reg |= (0xf1 << PMU_TDC0_REF_CAL_CNT_OFFS);
-       writel(reg, priv->control1);

        /* Reset the sensor */
-       reg = readl_relaxed(priv->control1);
-       writel((reg | PMU_TDC0_SW_RST_MASK), priv->control1);
+       reg |= PMU_TDC0_SW_RST_MASK;

        writel(reg, priv->control1);

@@ -129,14 +126,13 @@ static void armada370_init_sensor(struct platform_device *pdev,

        reg = readl_relaxed(priv->control1);
        reg |= PMU_TDC0_OTF_CAL_MASK;
-       writel(reg, priv->control1);

        /* Reference calibration value */
        reg &= ~PMU_TDC0_REF_CAL_CNT_MASK;
        reg |= (0xf1 << PMU_TDC0_REF_CAL_CNT_OFFS);
-       writel(reg, priv->control1);

        reg &= ~PMU_TDC0_START_CAL_MASK;
+
        writel(reg, priv->control1);
 

IIRC, the documentation for this hardware block was a meager.

Are you sure there isn't any requirement for the calibration
start to be issued separately or something like that?

I didn't find any info about this, I don't think it will be a problem
if my understanding of this IP is correct (had a lot of interactions
with Marvell engineers) but cannot be 100% sure, if someone has a
problem we'll know where to look at.

Thanks,
Miqu?l