Hi Vladimir,

On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy
[off-list ref] wrote:

On 05/30/2018 03:03 PM, Cl?ment P?ron wrote:

quoted

From: Colin Didier <redacted>

Add missing compatible and clock properties for EPIT node.

Signed-off-by: Colin Didier <redacted>
Signed-off-by: Cl?ment Peron <redacted>
Reviewed-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index c003e62bf290..0feec516847a 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi

@@ -844,13 +844,23 @@
                      };

                      epit1: epit at 20d0000 { /* EPIT1 */

epit1: timer at 20d0000 { ...

And /* EPIT1 */ comment can be removed, it is quite clear from the same
line context.

Formally it is a subject to another patch, but I think this can be
accepted as a part of this one.

Should I also update other boards ?
I only did it for imx6qdl.dtsi, but the EPIT is present in other boards
but i can't test it myself.

quoted

+                             compatible = "fsl,imx6q-epit", "fsl,imx31-epit";
                              reg = <0x020d0000 0x4000>;
                              interrupts = <0 56 IRQ_TYPE_LEVEL_HIGH>;
+                             clocks = <&clks IMX6QDL_CLK_IPG_PER>,
+                                      <&clks IMX6QDL_CLK_EPIT1>;
+                             clock-names = "ipg", "per";
+                             status = "disabled";
                      };

                      epit2: epit at 20d4000 { /* EPIT2 */

Same as above.

quoted

+                             compatible = "fsl,imx6q-epit", "fsl,imx31-epit";
                              reg = <0x020d4000 0x4000>;
                              interrupts = <0 57 IRQ_TYPE_LEVEL_HIGH>;
+                             clocks = <&clks IMX6QDL_CLK_IPG_PER>,
+                                      <&clks IMX6QDL_CLK_EPIT2>;
+                             clock-names = "ipg", "per";
+                             status = "disabled";
                      };

                      src: src at 20d8000 {

--
With best wishes,
Vladimir