On 2018-05-11 8:22 PM, Rob Herring wrote:

On Thu, May 10, 2018 at 4:16 AM,  [off-list ref] wrote:

quoted

From: Levin Du <redacted>

Adding a new gpio controller named "gpio-syscon10" to rk3328, providing
access to the pins defined in the syscon GRF_SOC_CON10.

Boards using these special pins to control regulators or LEDs, can now
utilize existing drivers like gpio-regulator and leds-gpio.

Signed-off-by: Levin Du <redacted>

---

Changes in v1:
- Split from V0 and add to rk3328.dtsi for general use.

  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index b8e9da1..73a822d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi

@@ -309,6 +309,12 @@
                         mode-loader = <BOOT_BL_DOWNLOAD>;
                 };

+               gpio_syscon10: gpio-syscon10 {

GPIO controller nodes should be named just 'gpio'.

'gpio' is a general name, and there're already gpio0~gpio3 for pinctrl 
GPIOs.

quoted

+                       compatible = "rockchip,gpio-syscon";
+                       gpio-controller;
+                       #gpio-cells = <2>;
+                       gpio,syscon-dev = <0 0x0428 0>;

This property is not documented and takes a phandle.

See PATCH1 which allows fetching syscon from parent node .
This is also documented in 
Documentation/devicetree/bindings/gpio/rockchip,gpio-syscon.txt
in PATCH2.

Thanks
Levin