[PATCH v1 3/5] arm64: dts: rockchip: Add gpio-syscon10 to rk3328
From: robin.murphy@arm.com (Robin Murphy)
Date: 2018-05-10 12:50:53
Also in:
linux-devicetree, linux-rockchip, lkml
On 10/05/18 10:16, djw at t-chip.com.cn wrote:
From: Levin Du <redacted> Adding a new gpio controller named "gpio-syscon10" to rk3328, providing access to the pins defined in the syscon GRF_SOC_CON10.
This is the GPIO_MUTE pin, right? The public TRM is rather vague, but cross-referencing against the datasheet and schematics implies that it's the "gpiomut_*" part of the GRF bit names which is most significant. It might be worth using a more descriptive name here, since "syscon10" is pretty much meaningless at the board level. Robin.
quoted hunk ↗ jump to hunk
Boards using these special pins to control regulators or LEDs, can now utilize existing drivers like gpio-regulator and leds-gpio. Signed-off-by: Levin Du <redacted> --- Changes in v1: - Split from V0 and add to rk3328.dtsi for general use. arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index b8e9da1..73a822d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi@@ -309,6 +309,12 @@ mode-loader = <BOOT_BL_DOWNLOAD>; }; + gpio_syscon10: gpio-syscon10 { + compatible = "rockchip,gpio-syscon"; + gpio-controller; + #gpio-cells = <2>; + gpio,syscon-dev = <0 0x0428 0>; + }; }; uart0: serial at ff110000 {