On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:

On 13/06/17 15:23, Jun Gao wrote:

quoted

On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:

quoted

On 13/06/17 12:24, Jun Gao wrote:

quoted

On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:

quoted

On 12/06/17 13:54, Jun Gao wrote:

quoted

On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:

quoted

From: Jun Gao <redacted>

Add MT2701 i2c device node.

Signed-off-by: Jun Gao <redacted>
---
    arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
    arch/arm/boot/dts/mt2701.dtsi    | 42 ++++++++++++++++++++++++++++++++++++++++
    2 files changed, 84 insertions(+)

[...]

quoted

Dear Matthias,

Could you take this patch together with
[PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?

Thanks!

They are both included in the pull request I send [1] [2], or do I miss
something?

Regards,
Matthias

[1]
https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
[2]
https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1

Dear Matthias,

Would you mind to use the same style as follows in i2c-mtk.txt of [2]?

"mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
"mediatek,mt6577-i2c": for Mediatek MT6577
"mediatek,mt6589-i2c": for Mediatek MT6589
"mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
"mediatek,mt8173-i2c": for Mediatek MT8173


Thanks!

You mean I should fix-up the patch to fit to the new binding
description? Or do you mean it should be MTxxxx instead of mtxxxx?

Regards,
Matthias

Dear Matthias,

I mean fix-up the patch to fit to the new binding description. Is it OK?

Then I can't see the difference between what you are asking for and what 
is already pushed to the repository. Please send a patch, that will make 
things clearer.

Regards,
Matthias

Dear Matthias,

like this:

diff:
 Required properties:
   - compatible: value should be either of the following.
-      (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
-      (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
-      (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
-      (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
-      (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
+       "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
MT2701
+       "mediatek,mt6577-i2c": for Mediatek MT6577
+       "mediatek,mt6589-i2c": for Mediatek MT6589
+       "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
MT7623
+       "mediatek,mt8173-i2c": for Mediatek MT8173
   - reg: physical base address of the controller and dma base, length
of memory
     mapped region.
   - interrupts: interrupt number to the cpu.


Thanks!