Thread (8 messages) flat view 8 messages, 2 authors, 2017-06-05

[PATCH 2/3] arm/xen: Delete an error message for a failed memory allocation in __set_phys_to_machine_multi()

From: sstabellini@kernel.org (Stefano Stabellini)
Date: 2017-06-05 17:17:38
Also in: kernel-janitors, lkml

On Sun, 4 Jun 2017, SF Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Sun, 4 Jun 2017 21:12:36 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <redacted>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
quoted hunk ↗ jump to hunk
---
 arch/arm/xen/p2m.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
index 11e78432b663..f5f74ac637b9 100644
--- a/arch/arm/xen/p2m.c
+++ b/arch/arm/xen/p2m.c
@@ -148,7 +148,6 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
-	if (!p2m_entry) {
-		pr_warn("cannot allocate xen_p2m_entry\n");
+	if (!p2m_entry)
 		return false;
-	}
+
 	p2m_entry->pfn = pfn;
 	p2m_entry->nr_pages = nr_pages;
 	p2m_entry->mfn = mfn;
-- 
2.13.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help