Thread (8 messages) flat view 8 messages, 2 authors, 2017-06-05
STALE3346d

[PATCH 3/3] arm/xen: Adjust one function call together with a variable assignment

From: SF Markus Elfring <hidden>
Date: 2017-06-04 21:08:04
Also in: kernel-janitors, lkml
Subsystem: arm port, the rest, xen hypervisor arm · Maintainers: Russell King, Linus Torvalds, Stefano Stabellini

From: Markus Elfring <redacted>
Date: Sun, 4 Jun 2017 21:21:20 +0200

The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <redacted>
---
 arch/arm/xen/p2m.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
index f5f74ac637b9..e71eefa2e427 100644
--- a/arch/arm/xen/p2m.c
+++ b/arch/arm/xen/p2m.c
@@ -153,7 +153,8 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
 	p2m_entry->mfn = mfn;
 
 	write_lock_irqsave(&p2m_lock, irqflags);
-	if ((rc = xen_add_phys_to_mach_entry(p2m_entry)) < 0) {
+	rc = xen_add_phys_to_mach_entry(p2m_entry);
+	if (rc < 0) {
 		write_unlock_irqrestore(&p2m_lock, irqflags);
 		return false;
 	}
-- 
2.13.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help