Thread (8 messages) flat view 8 messages, 2 authors, 2017-06-05

[PATCH 1/3] arm/xen: Improve a size determination in __set_phys_to_machine_multi()

From: sstabellini@kernel.org (Stefano Stabellini)
Date: 2017-06-05 17:16:51
Also in: kernel-janitors, lkml

On Sun, 4 Jun 2017, SF Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Sun, 4 Jun 2017 20:50:55 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <redacted>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

quoted hunk ↗ jump to hunk
---
 arch/arm/xen/p2m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
index 0ed01f2d5ee4..11e78432b663 100644
--- a/arch/arm/xen/p2m.c
+++ b/arch/arm/xen/p2m.c
@@ -144,5 +144,5 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
 		return true;
 	}
 
-	p2m_entry = kzalloc(sizeof(struct xen_p2m_entry), GFP_NOWAIT);
+	p2m_entry = kzalloc(sizeof(*p2m_entry), GFP_NOWAIT);
 	if (!p2m_entry) {
-- 
2.13.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help