Thread (29 messages) 29 messages, 3 authors, 2017-03-14

[PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards

From: krzk@kernel.org (Krzysztof Kozlowski)
Date: 2017-03-14 13:36:46
Also in: linux-devicetree, linux-samsung-soc, linux-watchdog, lkml

On Tue, Mar 14, 2017 at 3:30 PM, Bartlomiej Zolnierkiewicz
[off-list ref] wrote:
On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote:
quoted
On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz
[off-list ref] wrote:
quoted
Hi,

On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote:
quoted
Watchdog module does not have external dependencies so it can be safely
enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based
boards.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Please first fix the driver w.r.t. infinite interrupt in soft mode
issue and only then enable it on more hardware.  IOW this patch
should be placed after patch #7 in the series.
The soft-interrupt mode is not the default one so this should not
cause any issues by default but I got your point. Makes sense. The
pity is the timing. There wasn't much interest in the patchset (no
comments since 24 of Feb) so I merged it yesterday evening. Does it
brake any platform/board?
OK, let it be as it as it doesn't break the default setup.

However please consider the fact that posting revised patches
(v2 was posted *yesterday*) for a review and then merging them
the same day is not a good practice..
v2 was posted on March 11, not yesterday but I got the point that the
rest of world is working from Monday not Sunday. :) And v1 was on 24
of Feb. Usually I try to give them more time but recently there is so
less interest in this that I gave up waiting. I will give them more
time in the future.

Thanks for review!

Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help