[PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-03-14 13:30:49
Also in:
linux-devicetree, linux-samsung-soc, linux-watchdog, lkml
On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote:
On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz [off-list ref] wrote:quoted
Hi, On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote:quoted
Watchdog module does not have external dependencies so it can be safely enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based boards. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>Please first fix the driver w.r.t. infinite interrupt in soft mode issue and only then enable it on more hardware. IOW this patch should be placed after patch #7 in the series.The soft-interrupt mode is not the default one so this should not cause any issues by default but I got your point. Makes sense. The pity is the timing. There wasn't much interest in the patchset (no comments since 24 of Feb) so I merged it yesterday evening. Does it brake any platform/board?
OK, let it be as it as it doesn't break the default setup. However please consider the fact that posting revised patches (v2 was posted *yesterday*) for a review and then merging them the same day is not a good practice.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics