Thread (29 messages) 29 messages, 3 authors, 2017-03-14

[PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412

From: krzk@kernel.org (Krzysztof Kozlowski)
Date: 2017-03-14 13:11:00
Also in: linux-devicetree, linux-samsung-soc, linux-watchdog, lkml

On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz
[off-list ref] wrote:
Hi,

On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote:
quoted
The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250).
Just like the others, for working it requires additional steps in Power
Management Unit: unmasking the reset request and enabling the system
reset.  Without these additional steps in PMU, the watchdog will not be
able to reset the system on expiration event.

Change the compatible of Exynos4412 watchdog device node to
samsung,exynos5250-wdt which includes the additional PMU steps.
This is going to confuse people.  How's about doing it cleanly
(by adding samsung,exynos4412-wdt compatible and convert existing
users to use instead)?
I don't find usage of 5250 in Exynos4412 DTS as confusing because
since long time I do not threat these numbers as having any meaning
(e.g. 3250 is newer...). Yes, we can duplicate the compatible for that
purpose. Care to send a patch for this?

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help