On Thu, Mar 09, 2017 at 03:42:49PM +0100, Bartlomiej Zolnierkiewicz wrote:

Hi,

On Thursday, March 09, 2017 01:57:15 PM Russell King - ARM Linux wrote:

quoted

On Thu, Mar 09, 2017 at 03:24:56PM +0300, Sergei Shtylyov wrote:

quoted

On 03/09/2017 03:20 PM, Sekhar Nori wrote:

quoted

[...]

quoted

quoted

quoted

diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c

b/arch/arm/mach-davinci/board-dm644x-evm.c
index 023480b75244..60a1f23890cd 100644

--- a/arch/arm/mach-davinci/board-dm644x-evm.c
+++ b/arch/arm/mach-davinci/board-dm644x-evm.c

@@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device

*phydev)
    return 0;
}

-#define HAS_ATA        IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
+#define HAS_ATA        IS_ENABLED(CONFIG_PATA_BK3710)

  I think it would be more correct to check for both libata and IDE
drivers here...

As I understand, the plan is to remove the IDE driver soon.

   I'm not sure DaveM would support any removals in drivers/ide/. He has
explicitly expressed his will to maintain the IDE driuver forever.

As I keep saying, there are ARM machines where the IDE driver works but
the PATA driver doesn't.  EBSA110's PCMCIA slots for instance.

Please be more specific, I'll be happy to help with migrating this
machines to libata PATA.

BTW the example you're giving has never worked with the old IDE
driver in the upstream kernel.

That's where you are wrong.  It worked for 10+ years with no
modifications in the upstream IDE driver or ide-cs driver - only the
patch I quoted was required.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.