[PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1
From: tj@kernel.org (Tejun Heo)
Date: 2016-11-15 16:21:18
Also in:
linux-devicetree, linux-ide, linux-scsi
Possibly related (same subject, not in this thread)
- 2016-11-09 · Re: [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1 · Tejun Heo <tj@kernel.org>
- 2016-11-09 · Re: [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1 · Rameshwar Sahu <hidden>
- 2016-10-20 · [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1 · Rameshwar Prasad Sahu <hidden>
- 2016-07-26 · [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1 · Rameshwar Prasad Sahu <hidden>
Hello, Rameshwar. On Fri, Nov 11, 2016 at 01:36:28PM +0530, Rameshwar Sahu wrote:
Hi Tejun, On Wed, Nov 9, 2016 at 10:15 PM, Tejun Heo [off-list ref] wrote:quoted
Hello, On Wed, Sep 14, 2016 at 04:15:00PM +0530, Rameshwar Sahu wrote:quoted
quoted
@@ -821,8 +823,6 @@ static int xgene_ahci_probe(struct platform_device*pdev) dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n", __func__); version = XGENE_AHCI_V1; - } else if (info->valid & ACPI_VALID_CID) { - version = XGENE_AHCI_V2;Can you please explain this part a bit? Everything else looks good to me.Here we should not assume XGENE_AHCI_V2 always in case of having valid _CID in ACPI table. I need to remove this assumption because V1_1 has also valid _CID for backward compatibly with v1.
Can you please repost with the above explanation added to the commit message? Thanks! -- tejun