Thread (42 messages) 42 messages, 6 authors, 2016-11-11

[PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver

From: Marc Zyngier <hidden>
Date: 2016-10-26 12:11:28
Also in: linux-acpi, linux-watchdog, lkml

On 26/10/16 12:10, Fu Wei wrote:
Hi Mark,

On 21 October 2016 at 00:37, Mark Rutland [off-list ref] wrote:
quoted
Hi,

As a heads-up, on v4.9-rc1 I see conflicts at least against
arch/arm64/Kconfig. Luckily git am -3 seems to be able to fix that up
automatically, but this will need to be rebased before the next posting
and/or merging.

On Thu, Sep 29, 2016 at 02:17:12AM +0800, fu.wei at linaro.org wrote:
quoted
+static int __init map_gt_gsi(u32 interrupt, u32 flags)
+{
+     int trigger, polarity;
+
+     if (!interrupt)
+             return 0;
Urgh.

Only the secure interrupt (which we do not need) is optional in this
manner, and (hilariously), zero appears to also be a valid GSIV, per
figure 5-24 in the ACPI 6.1 spec.

So, I think that:

(a) we should not bother parsing the secure interrupt
If I understand correctly, from this point of view, kernel don't
handle the secure interrupt.
But the current arm_arch_timer driver still enable/disable/request
PHYS_SECURE_PPI
with PHYS_NONSECURE_PPI.
That means we still need to parse the secure interrupt.
Please correct me, if I misunderstand something? :-)
That's because we can use the per-cpu timer when 32bit Linux is running
on the secure side (and we cannot distinguish between secure and
non-secure at runtime). ACPI is 64bit only, and Linux on 64bit isn't
supported on the secure side, so only registering the non-secure timer
is perfectly acceptable.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help