Thread (9 messages) flat view 9 messages, 2 authors, 2016-09-12
DORMANTno replies

Revision v4 of 12 in this series.

Revisions (12)
  1. v2 [diff vs current]
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v3 [diff vs current]
  5. v4 [diff vs current]
  6. v4 [diff vs current]
  7. v4 [diff vs current]
  8. v4 [diff vs current]
  9. v4 [diff vs current]
  10. v4 current
  11. v5 [diff vs current]
  12. v5 [diff vs current]

[PATCH v4 2/3] arm64: dts: Add ZTE ZX296718 SoC dts and Makefile

From: shawnguo@kernel.org (Shawn Guo)
Date: 2016-09-12 12:18:00

On Fri, Sep 09, 2016 at 07:53:36PM +0800, Shawn Guo wrote:
A bit more comments as below ...

On Tue, Sep 06, 2016 at 02:04:20PM +0800, Jun Nie wrote:
quoted
+	soc {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "simple-bus";
+		interrupt-parent = <&gic>;
+		ranges;
+
+		timer {
+			compatible = "arm,armv8-timer";
+			interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
+				     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
+				     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
+				     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
Affinity bits are missing for PPI interrupt.  You can use a bit help
from defines in include/dt-bindings/interrupt-controller/arm-gic.h.
Sorry, I missed the fact that affinity bits is only required for gic-v2,
while what we have here is a gic-v3.  So please ignore the comment.

Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help