Thread (25 messages) 25 messages, 4 authors, 2016-07-19

[RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

From: jassisinghbrar@gmail.com (Jassi Brar)
Date: 2016-07-04 15:25:53
Also in: linux-amlogic, lkml

On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar [off-list ref] wrote:
On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong [off-list ref] wrote:
quoted
My main question is : do you really want to transform this simple driver into
a dirty multi-bus generic mailbox driver ?
The meson_mhu is only 199 lines and this patch adds 181 lines to the arm_mhu driver.

I'll personally push to have two separate drivers here.
It is a shame if we need to copy a driver only due to changed register
offsets. Let me give it a shot and see how worse off we would be.
OK, so I trimmed the differences further but it still doesn't look any
better. The best approach seems to be have a separate driver but with
consideration that its a 3rd party IP and hence likely to be used by
other platforms. That is, call it something meson-neutral. I will make
a few comments on the patch post.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help