[PATCH 6/6] clk: bcm2835: clean up coding style issues
From: Eric Anholt <hidden>
Date: 2016-02-29 20:20:05
Also in:
linux-clk
kernel at martin.sperl.org writes:
quoted hunk ↗ jump to hunk
From: Martin Sperl <redacted> Fix all the checkpatch complaints for clk-bcm2835.c Signed-off-by: Martin Sperl <redacted> --- drivers/clk/bcm/clk-bcm2835.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index da77069..105a42f 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c@@ -12,9 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /**@@ -300,7 +297,7 @@ struct bcm2835_cprman { struct device *dev; void __iomem *regs; - spinlock_t regs_lock; + spinlock_t regs_lock; /* spinlock for all clocks */ const char *osc_name;
I don't think this comment adds anything at all, but I understand you're trying to shut checkpatch up and I don't think there's much to say. I'd drop it, but I won't block the patch for it. Everything else in the patch looks good. Acked-by: Eric Anholt <redacted> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 818 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160229/c29e5ef3/attachment.sig>