Thread (20 messages) 20 messages, 2 authors, 2016-04-26

[PATCH 2/6] clk: bcm2835: add locking to pll*_on/off methods

From: Eric Anholt <hidden>
Date: 2016-02-29 20:06:28
Also in: linux-clk

kernel at martin.sperl.org writes:
From: Martin Sperl <redacted>

Add missing locking to:
* bcm2835_pll_divider_on
* bcm2835_pll_divider_off
to protect the read modify write cycle for the
register access protecting both cm_ctl and a2w_ctl
registers.
s/ctl/reg/ in the commit message

bcm2835_pll_divider_set_rate() also does an RMW on cm_reg, why was it
left out?

Since the a2w reg is only modified by _on and _off, and the core holds
the prepare lock across those, I think it was already safe and doesn't
need to be mentioned here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160229/39df8abd/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help