On 5 February 2016 at 00:43, Timur Tabi [off-list ref] wrote:

Mathieu Poirier wrote:

quoted

quoted

quoted

+#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC
+       irq = platform_get_irq(pdev, 0);
+       if (irq < 0) {
+               dev_err(dev, "unable to get ws0 interrupt.\n");
+               return irq;
+       }
+#endif
+

Can't the driver revert to single stage mode if platform_get_irq()
fails?  That way the value of 'irq' can be tested throughout the
_probe() function and the #ifdefs removed.

I like that idea.  The same can be done with the devm_request_irq() call.
It should definitely still display a warning if the command-line option is
set but no interrupt is available.

Yes, I agree with that too, brilliant idea, this will be in v11 patchset



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021