On Tuesday 15 December 2015, Yury Norov wrote:
quoted hunk ↗ jump to hunk
+
+#define compat_sys_open_by_handle_at sys_open_by_handle_at
+#define compat_sys_openat sys_openat
+
One more thing I just remembered: I think we want this behavior for all new
32-bit architectures, it was a bug to call compat_sys_openat for the generic
syscall table, as we don't support 32-bit off_t.
Could you split this out into a separate patch that does these changes:
- change the default asm-generic/unistd.h to use sys_openat/sys_open_by_handle_at
- change tile to override those two to keep the current (suboptimal) behavior
- change the force_o_largefile() definition so it defaults to true for all future
architectures. The easiest way is probably to add a Kconfig symbol for this
that gets selected by all 32-bit architectures, so we can use
#define force_o_largefile() ((BITS_PER_LONG != 32) || !IS_ENABLED(CONFIG_ARCH_32BIT_OFF_T))
Arnd