[PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708

On 11/07/2015 12:27 AM, Hauke Mehrtens wrote:

On 11/06/2015 11:54 PM, Jon Mason wrote:

quoted

On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote:

quoted

On 11/06/2015 10:11 PM, Kapil Hali wrote:

quoted

From: Jon Mason <redacted>

Add SMP support for Broadcom's 4708 SoCs.

Signed-off-by: Jon Mason <redacted>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Kapil Hali <redacted>

I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked.

quoted

---
 arch/arm/boot/dts/bcm4708.dtsi | 2 ++
 arch/arm/mach-bcm/Kconfig      | 1 +
 arch/arm/mach-bcm/Makefile     | 3 +++
 3 files changed, 6 insertions(+)

...

quoted

--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig

@@ -54,6 +54,7 @@ config ARCH_BCM_NSP
 config ARCH_BCM_5301X
 	bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7
 	select ARCH_BCM_IPROC

You activated ARM_ERRATA_764369 for NSP is this not needed for NS?

I'm not certain the CPU version, and without that it is difficult to
know what errata's are present in the underlying hardware.  My guess
is that all present in NSP are present in NS (for UP and SMP).  This
would put it as:
        select ARM_ERRATA_754322
        select ARM_ERRATA_775420
        select ARM_ERRATA_764369 if SMP

Would you like me to have them added?

I will send a separate patch adding all the workarounds for erratas in
the CPU core and the cache controller.

Hauke

Hi,

BCM4708 uses a Cortex-A9 rev r3p0 and a L2C-310 rev r3p2. For this CPU
and cache controller the same workaround are needed as for NSP, if you
will resend this patch, please add all of them.

Hauke