On Mon, Oct 12, 2015 at 9:29 AM, Thomas Petazzoni
[off-list ref] wrote:

On Mon, 12 Oct 2015 09:18:52 +0200, Geert Uytterhoeven wrote:

quoted

quoted

                pd = kzalloc(sizeof(*pd), GFP_KERNEL);
-               if (!pd)
+               if (!pd) {
+                       of_node_put(np);
                        return -ENOMEM;
+               }

While technically this patch is correct, the system will be dead anyway if it
ever goes OOM at core_initcall() time.

Then BUG_ON(!pd); ?

kzalloc() will scream anyway.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds