Thread (15 messages) 15 messages, 5 authors, 2015-10-12

[PATCH 5/5] arm: add missing of_node_put

From: arnd@arndb.de (Arnd Bergmann)
Date: 2015-10-10 21:02:31
Also in: kernel-janitors, lkml

On Saturday 10 October 2015 14:30:54 Julia Lawall wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
index 11c54de..432ff34 100644
--- a/arch/arm/kernel/devtree.c
+++ b/arch/arm/kernel/devtree.c
@@ -143,6 +143,7 @@ void __init arm_dt_init_cpu_maps(void)
                                               "max cores %u, capping them\n",
                                               cpuidx, nr_cpu_ids)) {
                        cpuidx = nr_cpu_ids;
+                       of_node_put(cpu);
                        break;
                }
The same for_each_child_of_node() loop has three 'return' statements'
aside from the 'break' statement here. I think you should change your
semantic patch to cover both cases.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help