On Mon, 12 Oct 2015, Geert Uytterhoeven wrote:

Hi Julia,

On Sat, Oct 10, 2015 at 2:30 PM, Julia Lawall [off-list ref] wrote:

quoted

--- a/arch/arm/mach-shmobile/pm-rmobile.c
+++ b/arch/arm/mach-shmobile/pm-rmobile.c

@@ -313,8 +313,10 @@ static int __init rmobile_add_pm_domains(void __iomem *base,
                }

                pd = kzalloc(sizeof(*pd), GFP_KERNEL);
-               if (!pd)
+               if (!pd) {
+                       of_node_put(np);
                        return -ENOMEM;
+               }

While technically this patch is correct, the system will be dead anyway if it
ever goes OOM at core_initcall() time.

Maybe it would be better for the code to be correct to serve as an example
(or to avoid serving as a bad example) for others?

julia