On Thursday 23 July 2015 09:22 PM, Lee Jones wrote:

On Tue, 21 Jul 2015, Vaibhav Hiremath wrote:

quoted

Update header file with required macros for 32KHz buffered clock
output of 88PM800 family of device.
These macros will be used in clk provider driver.

Signed-off-by: Vaibhav Hiremath <redacted>
---
  include/linux/mfd/88pm80x.h | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
index 05d9bad..680e4eb 100644
--- a/include/linux/mfd/88pm80x.h
+++ b/include/linux/mfd/88pm80x.h

@@ -91,6 +91,7 @@ enum {
  /* Referance and low power registers */
  #define PM800_LOW_POWER1		(0x20)
  #define PM800_LOW_POWER2		(0x21)
+#define PM800_LOW_POWER2_XO_LJ_EN	BIT(5)

  #define PM800_LOW_POWER_CONFIG3		(0x22)
  #define PM800_LDOBK_FREEZE		BIT(7)

@@ -138,6 +139,13 @@ enum {
  #define PM800_ALARM			BIT(5)
  #define PM800_RTC1_USE_XO		BIT(7)

+#define PM800_32K_OUTX_SEL_MASK		(0x3)
+/* 32KHz clk output sel mode */
+#define PM800_32K_OUTX_SEL_ZERO		(0x0)
+#define PM800_32K_OUTX_SEL_INT_32KHZ	(0x1)
+#define PM800_32K_OUTX_SEL_XO_32KHZ	(0x2)
+#define PM800_32K_OUTX_SEL_HIZ		(0x3)

Why do these need to be in brackets?

No specific reason, just made it consistent with other definitions in
the file.

I will fix in V2.

Thanks,
Vaibhav