Thread (44 messages) 44 messages, 14 authors, 2015-07-08

[PATCH 10/15] PCI: kill off set_irq_flags usage

From: robh@kernel.org (Rob Herring)
Date: 2015-06-18 20:09:04
Also in: linux-omap, linux-pci, linux-sh, linux-tegra, lkml

On Thu, Jun 18, 2015 at 11:59 AM, Bjorn Helgaas [off-list ref] wrote:
On Tue, Jun 09, 2015 at 01:26:36PM -0500, Rob Herring wrote:
quoted
set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also set IRQ_NOPROBE and this has been maintained although it is not
clear that is really needed. There appears to be a great deal of blind
copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Kishon Vijay Abraham I <redacted>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Murali Karicheri <redacted>
Cc: Thierry Reding <redacted>
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Pratyush Anand <pratyush.anand@gmail.com>
Cc: Simon Horman <horms@verge.net.au>
Cc: Michal Simek <redacted>
Cc: "S?ren Brinkmann" <redacted>
Cc: linux-omap at vger.kernel.org
Cc: linux-pci at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
Cc: linux-sh at vger.kernel.org
This is the only part of the series on linux-pci, so I assume this will be
merged by somebody else along with the rest.
I copied you on the intro, but all the lists and all the maintainers
was too long to cc. Being late in the cycle I didn't really intend for
this to be for 4.2, but you can pick up this patch if you want to as
it doesn't have any dependencies. If you don't, then I will submit the
whole series for 4.3.
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Thanks.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help