Thread (44 messages) 44 messages, 14 authors, 2015-07-08

[PATCH 05/15] gpio: kill off set_irq_flags usage

From: Linus Walleij <hidden>
Date: 2015-06-10 12:43:15
Also in: linux-gpio, linux-tegra, lkml

On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring [off-list ref] wrote:
set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also set IRQ_NOPROBE and this has been maintained although it is not
clear that is really needed. There appears to be a great deal of blind
copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Linus Walleij <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Stephen Warren <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-gpio at vger.kernel.org
Cc: bcm-kernel-feedback-list at broadcom.com
Cc: linux-tegra at vger.kernel.org
Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help