Thread (44 messages) 44 messages, 14 authors, 2015-07-08

[PATCH 00/15] Kill off set_irq_flags

From: Russell King - ARM Linux <hidden>
Date: 2015-06-09 20:30:42
Also in: lkml

On Tue, Jun 09, 2015 at 01:26:26PM -0500, Rob Herring wrote:
This series converts all users of ARM specific set_irq_flags to use
common genirq functions. In many cases where irqdomains are used, the
set_irq_flags calls were redundant, so I've removed them.

This is not intended for 4.2, but if any subsystem maintainers want to
pick up their subsystem's change that is fine. All but the last 2
patches stand on their own. Any new drivers going into 4.2 may need a
similar change, but I'm sure people are told not to use set_irq_flags in
reviews. ;)
So what are you doing about the initial state of IRQs on legacy ARM where
IRQs start off being un-requestable, and need the set_irq_flags() to make
them requestable.  I think you could be introducing a massive regression
by making this change.

Unless you can prove that this isn't the case, you shouldn't be removing
this stuff, especially not from legacy platforms.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help