[Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances
From: Stephen Boyd <hidden>
Date: 2015-02-06 01:49:33
Also in:
cocci, linux-omap, lkml
On 02/05/15 08:02, Quentin Lambert wrote:
quoted hunk ↗ jump to hunk
Sorry let me do that properly. On 05/02/2015 16:45, Quentin Lambert wrote:quoted
On 05/02/2015 00:26, Stephen Boyd wrote:quoted
quoted
If you want me to I can enlarge the search to other directories.Yes please do. And if you could share the coccinelle patch that would be great. Thanks.structclk.cocci is the coccinelle patch structclk-arm.patch is the result I got when applying it to the arch/arm directory Is there anything else I can do to help?These are the new instances I found by applying the patch to arch/arm directory: ./arch/arm/mach-imx/mach-imx6q.c@@ -211,7 +211,6 @@ static void __init imx6q_1588_init(void) * set bit IOMUXC_GPR1[21]. Or the PTP clock must be from pad * (external OSC), and we need to clear the bit. */ clksel = ptp_clk == enet_ref ? IMX6Q_GPR1_ENET_CLK_SEL_ANATOP : IMX6Q_GPR1_ENET_CLK_SEL_PAD; gpr = syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr"); if (!IS_ERR(gpr))
This one looks like a real problem and it could probably use a clk_equal(struct clk *a, struct clk *b) function.
quoted hunk ↗ jump to hunk
./arch/arm/mach-shmobile/clock-r8a73a4.c@@ -139,7 +139,6 @@ static int pll_set_parent(struct clk *cl /* Search the parent */ for (i = 0; i < clk->parent_num; i++) if (clk->parent_table[i] == parent) break; if (i == clk->parent_num)./arch/arm/mach-shmobile/clock-sh7372.c@@ -223,7 +223,6 @@ static int pllc2_set_parent(struct clk * /* Search the parent */ for (i = 0; i < clk->parent_num; i++) if (clk->parent_table[i] == parent) break; if (i == clk->parent_num)./arch/arm/mach-shmobile/clock-r8a7740.c@@ -195,7 +195,6 @@ static int usb24s_set_parent(struct clk /* Search the parent */ for (i = 0; i < clk->parent_num; i++) if (clk->parent_table[i] == parent) break; if (i == clk->parent_num)
I don't think shmobile uses the CCF so this should be safe, but we should probably fix them up to also use a clk_equal() function that just does pointer comparisons. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project