On Thursday 25 September 2014 10:35:45 Catalin Marinas wrote:

On Wed, Sep 24, 2014 at 07:40:18PM +0100, Arnd Bergmann wrote:

quoted

On Wednesday 24 September 2014 18:10:48 Catalin Marinas wrote:

quoted

quoted

The intention is not to have a second definition, instead this should
enable the default value just for arm64. Thus I put it to
arch/arm64/Kconfig. Otherwise it would be enabled per default on all
archs.

I don't think other architectures actually see the PCI symbol that is
defined in the arm64 Kconfig file, but I might be wrong.

Other archs wouldn't see the symbols in arch/arm64/Kconfig.

Ok.

quoted

quoted

quoted

We could have used select in config ARM64, but I tried to avoid using
select due to the dependency issue and instead implement this with
default-y/depends-on. Doing so it can be manually disabled too.

How about adding a new symbol like

config ARM64_PCI
      def_bool PCI
      select PCI_MSI

How is this different from just selecting PCI_MSI in config PCI in
arch/arm64/Kconfig? I don't see what another symbol brings.

That suggestion was just in case I was wrong above. If the symbol
is indeed hidden elsewhere, we don't need it.

	Arnd