[PATCH v3 16/17] ARM64 / ACPI: Enable ARM64 in Kconfig
From: Lorenzo Pieralisi <hidden>
Date: 2014-09-11 15:18:48
Also in:
linux-acpi, lkml
On Mon, Sep 01, 2014 at 03:57:54PM +0100, Hanjun Guo wrote:
From: Graeme Gregory <redacted> Add Kconfigs to build ACPI on ARM64, and make ACPI available on ARM64. acpi_idle driver is x86/IA64 dependent now, so make CONFIG_ACPI_PROCESSOR depend on X86 || IA64, and implement it on ARM64 in the future.
So are S states. Maybe I am being pedantic, but why can't you do the same thing for drivers/acpi/sleep.c ? Is it really that complicated to add a config option and avoid compiling it (that file supports a part of the ACPI specs that is completely undefined for ARM64), and with that removing the need for useless hooks on ARM64 ? Why do we have to compile that code at all on ARM64 ? Thanks, Lorenzo
quoted hunk ↗ jump to hunk
Reviewed-by: Grant Likely <redacted> Signed-off-by: Graeme Gregory <redacted> Signed-off-by: Al Stone <redacted> Signed-off-by: Hanjun Guo <redacted> --- arch/arm64/Kconfig | 2 ++ drivers/acpi/Kconfig | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-)diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 065438c..8dabaeb 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig@@ -422,6 +422,8 @@ source "drivers/Kconfig" source "drivers/firmware/Kconfig" +source "drivers/acpi/Kconfig" + source "fs/Kconfig" source "arch/arm64/kvm/Kconfig"diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index d0f3265..f935d2e 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig@@ -5,8 +5,7 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" depends on !IA64_HP_SIM - depends on IA64 || X86 - depends on PCI + depends on ((IA64 || X86) && PCI) || (ARM64 && EXPERT) select PNP default y help@@ -163,6 +162,7 @@ config ACPI_PROCESSOR tristate "Processor" select THERMAL select CPU_IDLE + depends on X86 || IA64 default y help This driver installs ACPI as the idle handler for Linux and uses@@ -263,7 +263,7 @@ config ACPI_DEBUG config ACPI_PCI_SLOT bool "PCI slot detection driver" - depends on SYSFS + depends on SYSFS && PCI default n help This driver creates entries in /sys/bus/pci/slots/ for all PCI-- 1.7.9.5