[PATCH v2 05/11] ARM: dts: zynq: Add QSPI for Parallella

On 07/25/2014 10:42 AM, Andreas F?rber wrote:

Am 25.07.2014 09:59, schrieb Michal Simek:

quoted

On 07/25/2014 01:18 AM, S?ren Brinkmann wrote:

quoted

On Fri, 2014-07-25 at 01:00AM +0200, Andreas F?rber wrote:

quoted

Prepare SPI0 and SPI1 while at it.

quoted

Patch subject is incorrect. You are adding SPI and QSPI.

Yes, it originally added only QSPI, but I considered it a good deed to
add SPI as well while already reading that part of the TRM. :)

quoted

quoted

quoted

Signed-off-by: Andreas F?rber <afaerber@suse.de> --- v2: New

arch/arm/boot/dts/zynq-7000.dtsi      | 37
+++++++++++++++++++++++++++++++++++ 
arch/arm/boot/dts/zynq-parallella.dts |  4 ++++ 2 files
changed, 41 insertions(+)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi

b/arch/arm/boot/dts/zynq-7000.dtsi index 8fd826a..eed3df0
100644 --- a/arch/arm/boot/dts/zynq-7000.dtsi +++
b/arch/arm/boot/dts/zynq-7000.dtsi @@ -122,6 +122,30 @@ 
interrupts = <0 50 4>; };

+		spi0: spi at e0006000 { +			compatible = "xlnx,zynq-spi-r1p6"; 
+			reg = <0xe0006000 0x1000>; +			status = "disabled"; +
interrupt-parent = <&intc>; +			interrupts = <0 26 4>; +
clocks = <&clkc 25>, <&clkc 34>; +			clock-names = "ref_clk",
"pclk"; +			#address-cells = <1>; +			#size-cells = <0>; +		}; 
+ +		spi1: spi at e0007000 { +			compatible =
"xlnx,zynq-spi-r1p6"; +			reg = <0xe0007000 0x1000>; +			status
= "disabled"; +			interrupt-parent = <&intc>; +			interrupts =
<0 49 4>; +			clocks = <&clkc 26>, <&clkc 35>; +			clock-names
= "ref_clk", "pclk"; +			#address-cells = <1>; +			#size-cells
= <0>; +		}; +

Until here things look good.

quoted

gem0: ethernet at e000b000 { compatible = "cdns,gem"; reg =
<0xe000b000 0x4000>; @@ -140,6 +164,19 @@ clock-names = "pclk",
"hclk", "tx_clk"; };

+		qspi: qspi at e000d000 { +			compatible =
"xlnx,zynq-spi-r1p6"; +			reg = <0xe000d000 0x1000>; +			status
= "disabled"; +			interrupt-parent = <&intc>; +			interrupts =
<0 19 4>; +			clocks = <&clkc 10>, <&clkc 43>; +			clock-names
= "ref_clk", "pclk"; +			num-cs = <1>; +			#address-cells =
<1>; +			#size-cells = <0>; +		}; +

I'm not sure what the status of this driver is. I think QSPI is
still under review on the mailing lists and I don't think we
should add this yet.

quoted

Driver for qspi is not in the mainline yet but it doesn't mean that
this fragment won't work. Harini: Can you please correct me if I am
wrong?

It did seem to find the flash chip (cf. parallella-next branch), but I
didn't find a driver capable of handling its ID. The downstream tree
was using m25p80; I tried both micron,n25q128a11 and ...a13 based on
U-Boot output.

quoted

I would prefer to send two separate patches.

Will do.

quoted

1. just add SPI to zynq

As I don't have any of the other Zynq boards, can you please advise
whether either of them should be enabled for some board?

we don't have them enabled for any board in default configuration
that's why just adding nodes with status = "disabled" is fine.

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140725/5a76e576/attachment.sig>