Thread (22 messages) 22 messages, 3 authors, 2014-07-13

[PATCHv4 2/4] ARM: Kirkwood: Add DT descriptions for net2big and net5big.

From: Jason Cooper <hidden>
Date: 2014-06-21 19:28:46
Subsystem: the rest · Maintainer: Linus Torvalds

On Sat, Jun 21, 2014 at 11:50:02AM +0200, Simon Guinot wrote:
On Sat, Jun 21, 2014 at 01:37:18AM +0200, Simon Guinot wrote:
quoted
On Mon, May 26, 2014 at 09:29:49PM +0200, Andrew Lunn wrote:
...
quoted
quoted
+&regulators {
+	regulator at 3 {
+		compatible = "regulator-fixed";
+		reg = <3>;
+		regulator-name = "hdd2power";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		enable-active-high;
+		regulator-always-on;
+		regulator-boot-on;
+		gpio = <&gpio0 19 GPIO_ACTIVE_HIGH>;
19 must be replaced with 9.
And gpio0 must replaced with gpio1.
quoted
quoted
+	};
+
+	regulator at 4 {
+		compatible = "regulator-fixed";
+		reg = <4>;
+		regulator-name = "hdd3power";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		enable-active-high;
+		regulator-always-on;
+		regulator-boot-on;
+		gpio = <&gpio0 20 GPIO_ACTIVE_HIGH>;
20 must be replaced with 10.
Here too.
quoted
quoted
+	};
+
+	regulator at 5 {
+		compatible = "regulator-fixed";
+		reg = <5>;
+		regulator-name = "hdd4power";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		enable-active-high;
+		regulator-always-on;
+		regulator-boot-on;
+		gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>;
21 must be replaced with 11.
And here too.
I've pushed the following to mvebu/dt:

--------->8--------------
commit d854fa8a1500bec982ed9cb26b82d96bd5ae8dab
Author: Jason Cooper [off-list ref]
Date:   Sat Jun 21 19:21:13 2014 +0000

    ARM: kirkwood: fix net5big regulator gpio assignments
    
    Late correction from Simon's testing.
    
    Reported-by: Simon Guinot [off-list ref]
    Link: https://lkml.kernel.org/r/20140621095001.GW20207 at kw.sim.vm.gnt
    Signed-off-by: Jason Cooper [off-list ref]
diff --git a/arch/arm/boot/dts/kirkwood-net5big.dts b/arch/arm/boot/dts/kirkwood-net5big.dts
index 51c56a9490b3..d2887ed493f2 100644
--- a/arch/arm/boot/dts/kirkwood-net5big.dts
+++ b/arch/arm/boot/dts/kirkwood-net5big.dts
@@ -40,7 +40,7 @@
 		enable-active-high;
 		regulator-always-on;
 		regulator-boot-on;
-		gpio = <&gpio0 9 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio1 9 GPIO_ACTIVE_HIGH>;
 	};
 
 	regulator at 4 {
@@ -52,7 +52,7 @@
 		enable-active-high;
 		regulator-always-on;
 		regulator-boot-on;
-		gpio = <&gpio0 10 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio1 10 GPIO_ACTIVE_HIGH>;
 	};
 
 	regulator at 5 {
@@ -64,7 +64,7 @@
 		enable-active-high;
 		regulator-always-on;
 		regulator-boot-on;
-		gpio = <&gpio0 11 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio1 11 GPIO_ACTIVE_HIGH>;
 	};
 };
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help