On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:

quoted

sata_writel() and sata_read() static inlines don't seem to add any value.

Can they be removed?

Such functions are quite idiomatic in drivers, and serve to simplify all
the call-sites by removing the need to write out the addition of the
base address everywhere.

I think it obfuscates more than helps.  If you absoluately have to
keep it, please at least name it so that it's clear that it's
something specific to this driver.

Thanks.

-- 
tejun