On 06/04/2014 05:32 AM, Mikko Perttunen wrote:
This patch adds device tree binding documentation for the SATA
controller found on NVIDIA Tegra SoCs.
Just one nit below:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/ata/tegra-sata.txt b/Documentation/devicetree/bindings/ata/tegra-sata.txt
+ - clocks : Defines the clocks listed in the clock-names property.
+ - clock-names : The following clock names must be present:
+ - sata
...
It would be nice if the binding could use the exact same wording as all
the other Tegra bindings, i.e.:
==========
- clocks : Must contain an entry for each entry in clock-names.
See ../clocks/clock-bindings.txt for details.
- clock-names : Must include the following entries:
- pll_a
- pll_a_out0
- mclk (The Tegra cdev1/extern1 clock, which feeds the CODEC's mclk)
==========
Same for the resets property.