Thread (63 messages) 63 messages, 6 authors, 2014-06-13

[PATCH V2 00/19] irqchip: crossbar: driver fixes

From: Thomas Gleixner <hidden>
Date: 2014-06-13 20:39:08
Also in: linux-devicetree, linux-omap, lkml

On Fri, 13 Jun 2014, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:48:24AM -0700, Joe Perches wrote:
quoted
On Fri, 2014-06-13 at 12:37 -0400, Jason Cooper wrote:
quoted
On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote:
quoted
On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote:
quoted
Please format the subject lines like so:

  irqchip: crossbar: Set cb pointer ...
                     ^
                     |
                     \-- note the capitalization
I suggest you don't make this a rule and focus
on more important stuff instead.
Says the one, who pesters people about typos in changelogs....

WTF? Jason is doing a great job in reviewing and he knows what to
concentrate on.
quoted
quoted
It's not my rule.  ;-)
Who's rule is it then?
Thomas'
Sentences start with an upper case letter. Our brain is trained on
that rule when parsing a line.

So for people who actually review patches by reading them instead of
running a spell checker, consistent formatting more important than
avoiding the random typo, which our brain just blends out in most of
the cases. Unfortunately also when the typo is in actual code :(

Thanks,

	tglx






   

   
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help