[PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

Hi Jason,

On Thursday 12 June 2014 09:35 PM, Joe Perches wrote:

On Thu, 2014-06-12 at 11:32 -0400, Jason Cooper wrote:

Hi Jason.

quoted

quoted

But bugfix backports haven't been much of an issue in
other subsystems with fairly active whitespace/style
changes.

Most of the mvebu fixes we've had that failed to apply were generally
due to a large whitespace change (dts node shuffling, admittedly not
checkpatch-related).

So not due to this.

quoted

  I've also frequently been stymied by code cleanups
when using git blame to find the commit introducing a regression.

git blame -w can frequently help there.

quoted

So, my general rule is: If you're submitting a patch to make checkpatch
be quiet, re-assess the need.  If you're making changes and you can fix
some checkpatch items while you're there, then do so.

Decent rule.

quoted

There are certainly legitimate checkpatch-only patches, I just don't
think this is one qualifies.

Of course it's the maintainer's choice (and last I saw,
that's you) to ignore whatever doesn't fit the appropriate
vision for the code.

$ ./scripts/get_maintainer.pl -f drivers/irqchip/irq-crossbar.c
Thomas Gleixner [off-list ref] (maintainer:IRQCHIP DRIVERS)
Jason Cooper [off-list ref] (maintainer:IRQCHIP DRIVERS)

 
  Ok, if this is not qualifying as a separate patch then i will merge
  this with other patches in the series which touch them.

Regards,
 Sricharan