Thread (31 messages) 31 messages, 7 authors, 2014-01-16

[PATCH 1/3] mmc: dw_mmc: use slot-gpio to handle cd pin

From: zhangfei.gao@linaro.org (zhangfei)
Date: 2014-01-15 01:09:09
Also in: linux-devicetree, linux-mmc


On 01/15/2014 01:23 AM, Olof Johansson wrote:
On Tue, Jan 14, 2014 at 7:58 AM, Kevin Hilman [off-list ref] wrote:
quoted
On Thu, Jan 9, 2014 at 6:35 AM, Zhangfei Gao [off-list ref] wrote:
quoted
Suggested by Jaehoon: Use slot-gpio to handle cd-gpio
Add function dw_mci_of_get_cd_gpio to check "cd-gpios" from dts.
mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
The Samsung Arndale board started failing boot from MMC root tests
starting with next-20140113 and I bisected it down to this patch.
Reverting this patch on top of next-20140114 gets Arndale booting
again from MMC.  Is there some supporting DT data that's missing for
Arndale?
Rather, it looks like this patch changes behaviour and no longer uses
dw_mci_get_cd() to find out if there's a card attached -- it switches
to rely only on GPIO (see the last chunk in the patch). That seems
broken?
Oops,
Change using dw_mci_get_cd set flag DW_MMC_CARD_PRESENT.
And dw_mci_get_cd is called from mmc_rescan, a litter later than 
dw_mci_probe.
Is that too late?

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help