Thread (225 messages) 225 messages, 19 authors, 2015-06-08

[PATCH 05/11] serial: support for 16550 serial ports on LP-8x4x

From: Russell King - ARM Linux <hidden>
Date: 2013-12-02 11:52:38
Also in: linux-serial, lkml

On Mon, Dec 02, 2013 at 03:39:26PM +0400, Sergei Ianovich wrote:
On Mon, 2013-12-02 at 11:30 +0000, Russell King - ARM Linux wrote:
quoted
On Sun, Dec 01, 2013 at 10:26:18AM +0400, Sergei Ianovich wrote:
quoted
+static struct platform_device lp8x4x_device = {
+	.name			= "serial8250",
+	.id			= PLAT8250_DEV_ACCENT,
You should not re-use the enum value here.  The enum is designed as a
method to provide the platform devices with a unique id, not as a means
to identify the manufacturer or anything else like that.
Should I add a new enum?
Add a new enum.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help