Thread (270 messages) 270 messages, 11 authors, 2013-10-04

[PATCH 211/228] cpufreq: tegra: remove calls to cpufreq_notify_transition()

From: Rafael J. Wysocki <hidden>
Date: 2013-09-15 04:54:47
Also in: linux-pm, lkml

On Saturday, September 14, 2013 09:39:31 AM Viresh Kumar wrote:
On 14 September 2013 04:22, Stephen Warren [off-list ref] wrote:
quoted
I wonder if this series is bisectable? Perhaps I should just go and read
the rest of the series, but I presume there's a patch somewhere else
that adds those two cpufreq_notify_transition() to the cpufreq core.
Either that happens before this patch (in which case listeners will get
two notifications each time; perhaps that is safe?), or after this patch
(in which case with just this patch applied, no notifications will be
sent until a later patch!
Hmm.. Good Catch..

So, yes git bisect would be compilable but not runnable.. As we are
already serialized notifications and so two PRE notifications will
generate a crash..

But I don't want to get all that in a single patch as that would be:

 40 files changed, 192 insertions(+), 623 deletions(-)

And that would be hard to review it..

Any suggestions?
Well, I guess you can assume that everyone has a chance to review the series
by now and send it as one patch in the next iteration.

A patch that adds 192 lines of code isn't shockingly large by any measure.

Thanks,
Rafael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help