Thread (270 messages) 270 messages, 11 authors, 2013-10-04

[PATCH 106/228] cpufreq: integrator: don't initialize part of policy that is set by core too

From: viresh.kumar@linaro.org (Viresh Kumar)
Date: 2013-09-13 16:29:15
Also in: linux-pm, lkml

On 13 September 2013 21:40, Russell King - ARM Linux
[off-list ref] wrote:
This patch actually changes things - the description is misleading.
Please explain why this change - which results in different values for
policy->min and policy->max doesn't cause any functional difference.
Yeah, see if below log looks correct (patch attached):

Subject: [PATCH 106/228] cpufreq: integrator: don't initialize part of policy
 that is set by core too

Many common initializations of struct policy are moved to core now and hence
this driver doesn't need to do it. This patch removes such code.

Most recent of those changes is to call ->get() in the core after calling
->init(). And so we don't need to set policy->cur from driver anymore.

Over that it sets policy->min and max correctly. They were earlier set to
current frequency of CPU but they should be set to max and min freq of cpu.

Cc: Russell King <redacted>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/integrator-cpufreq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0106-cpufreq-integrator-don-t-initialize-part-of-policy-t.patch
Type: application/octet-stream
Size: 1805 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130913/e71c1e56/attachment.obj>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help