Thread (32 messages) 32 messages, 6 authors, 2013-06-18
STALE4757d

[PATCH v3 10/10] ARM: Exynos: extend soft-reset support for Exynos5420

From: arnd@arndb.de (Arnd Bergmann)
Date: 2013-06-17 12:21:49
Also in: linux-samsung-soc, linux-serial 

On Monday 17 June 2013 16:30:35 Chander Kashyap wrote:
quoted hunk ↗ jump to hunk
@@ -330,10 +330,10 @@ void exynos5_restart(char mode, const char *cmd)
        u32 val;
        void __iomem *addr;
 
-       if (of_machine_is_compatible("samsung,exynos5250")) {
-               val = 0x1;
-               addr = EXYNOS_SWRESET;
-       } else if (of_machine_is_compatible("samsung,exynos5440")) {
+       val = 0x1;
+       addr = EXYNOS_SWRESET;
+
+       if (of_machine_is_compatible("samsung,exynos5440")) {
                u32 status;
                np = of_find_compatible_node(NULL, NULL, "samsung,exynos5440-clock");
 
Please try to avoid adding further uses of hardcoded MMIO addresses.

Can you change that to use the same logic that exynos5440 has?

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help