On Mon, Jun 10, 2013 at 12:46:59PM +0100, Srinivas KANDAGATLA wrote:

quoted

    +       aux_ctrl = (0x1 << L2X0_AUX_CTRL_SHARE_OVERRIDE_SHIFT) |
    +               (0x1 << L2X0_AUX_CTRL_DATA_PREFETCH_SHIFT) |
    +               (0x1 << L2X0_AUX_CTRL_INSTR_PREFETCH_SHIFT) |
    +               (way_size << L2X0_AUX_CTRL_WAY_SIZE_SHIFT);



#include <linux/bitops.h>
Linus Walleij would write use  BIT() here

I will use BIT() macro.

Without checking those fields... BIT() is only appropriate if you're
really talking about single bits.  If you have a field of more than a
single bit which you happen to be setting to '1' then it's not
appropriate to use BIT().