On Thu, May 09, 2013 at 12:38:19PM +0900, Simon Horman wrote:

On Wed, May 08, 2013 at 03:22:22PM +0200, Bastian Hecht wrote:

quoted

Hi,

2013/5/8 Arnd Bergmann [off-list ref]:

quoted

On Thursday 02 May 2013, Simon Horman wrote:

quoted

quoted

quoted

diff --git a/arch/arm/mach-shmobile/intc-r8a7740.c b/arch/arm/mach-shmobile/intc-r8a7740.c
index 8871f77..5dc57f1 100644
--- a/arch/arm/mach-shmobile/intc-r8a7740.c
+++ b/arch/arm/mach-shmobile/intc-r8a7740.c

@@ -53,14 +53,23 @@ static void __init r8a7740_init_irq_common(void)

 void __init r8a7740_init_irq_of(void)
 {
+       if (!IS_ENABLED(CONFIG_OF))
+               return;
+
        irqchip_init();

Why not have an empty irqchip_init? I'd guess we'll need this on other
platforms and your default mach.

Thanks, I think that could work.

I will see about making it so.

Ping

I have sent out a patch adding an empty irqchip_init() when
CONFIG_IRQCHIP is not set with the subject
[PATCH] irqchip: Add irqchip_init dummy function

Thanks.

quoted

quoted

Linux-next is still broken for me. There is also anothe shmobile build bug,
I'll send a separate patch for that, which also needs to go into your tree.

Sorry about that. I though I had pushed your fix (the first hunk of the
patch that started this thread), but it seems that I did not.

Sorry once again for the delay in addressing this.
I have pushed a refreshed next branch which includes
both Bastian's fix for irqchip_init() and the patch
that Arnd posted relating to symbol renames.

These changes should appear in linux-next in the not to distant future.